Attention is currently required from: Felix Singer, Reto Buerki.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9:
Add ENABLE_MSATA config knob and pad configuration to put Mini PCIe port
into mSATA mode.
I think we should figure out if PCIe still works, so that we don't create confusion. […]
I've checked pinouts of mini PCIe and mSATA, they use the same pins for their
lanes. And as Apollo Lake has these on separate pins, there is no other reasonable
way to hook this up than a separate muxer. So it seems 99% sure that PCIe doesn't
work with SATA enabled and vice versa, and I don't see why one would expect
otherwise.
Making it a choice in Kconfig seems right to me.
To view, visit change 80261. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic2da1dd4252ebb5e373bc65418e321f566d4c10f
Gerrit-Change-Number: 80261
Gerrit-PatchSet: 2
Gerrit-Owner: Reto Buerki <reet@codelabs.ch>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Reto Buerki <reet@codelabs.ch>
Gerrit-Comment-Date: Thu, 08 Feb 2024 20:28:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Reto Buerki <reet@codelabs.ch>
Gerrit-MessageType: comment