3 comments:
File src/mainboard/google/hatch/romstage.c:
Patch Set #3, Line 22: struct
static
Patch Set #3, Line 24: const
static
File src/mainboard/google/hatch/variants/baseboard/memory.c:
Making the struct non-const results in the error that I mentioned before: […]
Aah yes!
We can probably do:
void __weak variant_memory_params(struct cnl_mb_cfg *bcfg)
{
memcpy(bcfg, &baseboard_memcfg, sizeof(baseboard_memcfg));
if (gpio_get(GPP_F2))
bcfg.single_channel = 1;
}
That way you don't have to split the above structure and do individual copies.
To view, visit change 31358. To unsubscribe, or for help writing mail filters, visit settings.