View Change
1 comment:
File src/Kconfig:
Patch Set #7, Line 252: default n if !ENABLE_STAGE_RAMSTAGE
i was just trying to make sure all root dependent kconfig doesn't get default select. […]
I don't understand what you're asking. What does "root dependent" mean? This has a 'depends on RELOCATABLE_RAMSTAGE', so it already transitively depends on ENABLE_RAMSTAGE anyway, but as I said dependencies don't matter for select. You cannot make sure this is not selected by another option. Kconfig just doesn't allow you to control that.
Just leave this like it was, I don't understand why anything has to change here. This isn't menuconfig-visible, and what value this config has for builds where it doesn't have any effect either way doesn't matter.
To view, visit change 33116. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: ron minnich <rminnich@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Sat, 08 Jun 2019 05:55:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik@intel.com>
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Gerrit-MessageType: comment