View Change
1 comment:
Commit Message:
Patch Set #105, Line 28: dGPU
As FSP does display configuration (iGFX, Switchable Graphics, etc) in FSP-M and UEFI configures the relevant GPIOs in PEI (see SwitchableGraphicsPei.c), I attempted to move the `gpu_reset` function into romstage.
It didn't work, but dmesg was displaying errors about being unable to transition the root port from D3 to D0, because the config space was unavailable.
An alternative is PrimaryDisplay=Display_SG and setting the Switchable Graphics GPIO UPDs.
To view, visit change 35523. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6340116abfeb2fbd280d143b74d323e4da3566f6
Gerrit-Change-Number: 35523
Gerrit-PatchSet: 105
Gerrit-Owner: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Benjamin Doron <benjamin.doron00@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Thu, 09 Apr 2020 02:39:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment