Attention is currently required from: Julius Werner.
10 comments:
File tests/lib/fmap-test.c:
Patch Set #4, Line 94: mem_rdev_fmap_ro.rdev.root = &mem_rdev_ro.rdev;
What are you trying to do here? This isn't legal. […]
Done
...and then here you immediately overwrite it here again... […]
Done
Patch Set #4, Line 98: assert_int_equal(FMAP_SECTION_RO_VPD_START, rdev->region.offset);
Please use the region_device_offset() and region_device_sz() accessors instead of accessing rdev mem […]
Done
Patch Set #4, Line 118: /* Function fmap_locate_area_as_rdev is not tested with NULL
See comment style I mentioned in the other patch (or on https://doc.coreboot.org/coding_style. […]
Done
How about actually writing to it here, and then maybe looking it up as an RO rdev again to confirm y […]
Done
Patch Set #4, Line 164: assert_int_equal(FMAP_SECTION_COREBOOT_START, ar.offset);
For regions we also have accessors (region_offset()/region_sz()).
Done
Patch Set #4, Line 204: ar.offset = 2142037;
Would be good to test both an out-of-bounds area (like you're doing here) and an incorrect in-bounds […]
Done
Patch Set #4, Line 221: fmap_locate_area("RW_SECTION_A", &ar);
Why is this call here? It does nothing and has nothing to do with the rest of the test. […]
Done
Patch Set #4, Line 251: fmap_locate_area(section_name, &ar);
same as above
Done
typo
Done
To view, visit change 48557. To unsubscribe, or for help writing mail filters, visit settings.