Felix Held submitted this change.
soc/intel/common/block/p2sb/p2sb: Add missing PCI IDs
The code is compiled on SKL/KBL, but the P2SB PCI IDs were missing.
Add them to make sure that the BAR0 doesn't change when running PCI
resource allocation.
Change-Id: I7cffbbc7d15dad14cccd122a081099b51dc1ce07
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35791
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/p2sb/p2sb.c
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index b828eaa..6abedb4 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3265,6 +3265,9 @@
#define PCI_DEVICE_ID_INTEL_GLK_P2SB 0x3192
#define PCI_DEVICE_ID_INTEL_LWB_P2SB 0xa1a0
#define PCI_DEVICE_ID_INTEL_LWB_P2SB_SUPER 0xa220
+#define PCI_DEVICE_ID_INTEL_SKL_LP_P2SB 0x9d20
+#define PCI_DEVICE_ID_INTEL_SKL_P2SB 0xa120
+#define PCI_DEVICE_ID_INTEL_KBL_P2SB 0xa2a0
#define PCI_DEVICE_ID_INTEL_CNL_P2SB 0x9da0
#define PCI_DEVICE_ID_INTEL_CNP_H_P2SB 0xa320
#define PCI_DEVICE_ID_INTEL_ICL_P2SB 0x34a0
diff --git a/src/soc/intel/common/block/p2sb/p2sb.c b/src/soc/intel/common/block/p2sb/p2sb.c
index 1df0567..14e1fd9 100644
--- a/src/soc/intel/common/block/p2sb/p2sb.c
+++ b/src/soc/intel/common/block/p2sb/p2sb.c
@@ -155,6 +155,8 @@
/*
* There's only one resource on the P2SB device. It's also already
* manually set to a fixed address in earlier boot stages.
+ * The following code makes sure that it doesn't change if the device
+ * is visible and the resource allocator is being run.
*/
mmio_resource(dev, PCI_BASE_ADDRESS_0, P2SB_BAR / KiB, P2SB_SIZE / KiB);
}
@@ -170,6 +172,9 @@
PCI_DEVICE_ID_INTEL_GLK_P2SB,
PCI_DEVICE_ID_INTEL_LWB_P2SB,
PCI_DEVICE_ID_INTEL_LWB_P2SB_SUPER,
+ PCI_DEVICE_ID_INTEL_SKL_LP_P2SB,
+ PCI_DEVICE_ID_INTEL_SKL_P2SB,
+ PCI_DEVICE_ID_INTEL_KBL_P2SB,
PCI_DEVICE_ID_INTEL_CNL_P2SB,
PCI_DEVICE_ID_INTEL_CNP_H_P2SB,
PCI_DEVICE_ID_INTEL_ICL_P2SB,
To view, visit change 35791. To unsubscribe, or for help writing mail filters, visit settings.