[coreboot-gerrit] [L] Change in coreboot[main]: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H

[Fabian Groffen (Code Review)]

Attention is currently required from: Angel Pons, Felix Singer, Patrick Rudolph.

Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77046?usp=email )

Change subject: mb/gigabyte/ga-h77m-d3h: Add Sandy/Ivy Bridge board GA-H77M-D3H
......................................................................


Patch Set 7:

(4 comments)

File src/mainboard/gigabyte/ga-h77m-d3h/acpi/pci.asl:

https://review.coreboot.org/c/coreboot/+/77046/comment/c2ed380c_2ebf718c :
PS7, Line 7: 	Name (_ADR, 0x001E0000)
> This can't be correct because the board uses a dedicated PCIe-to-PCI bridge chip instead of the sout […]
> I admit copying this from ga-b75m-d3h.  I have that board too, and assumed this would be ok/correct.

I have no idea what do to different here.


File src/mainboard/gigabyte/ga-h77m-d3h/acpi/thermal.asl:

PS7:
> Has this been tested?
> no, it's from the b75m variant with identical superio

File src/mainboard/gigabyte/ga-h77m-d3h/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/77046/comment/e9852a7d_d2b8d0fe :
PS7, Line 5: 			subsystemid 0x1458 0x5000
> Same ID already gets inherited, you can omit this line
> if you don't mind my asking, where is this inherited from?  A git grep shows dozens of occurrences, but nothing that looks like something that would be included by this port.

File src/mainboard/gigabyte/ga-h77m-d3h/dsdt.asl:

https://review.coreboot.org/c/coreboot/+/77046/comment/61c55c2b_7694dbac :
PS7, Line 10: // OEM revision
> I think autoport hardcodes this value, as well as the comment. […]
> I created this port by adapting ga-b75m-d3h.