Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50024 )
Change subject: mb/emulation/qemu-q35: Consolidate host bridge definitions
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/emulation/qemu-q35/memmap.c:
https://review.coreboot.org/c/coreboot/+/50024/comment/b447a525_9a4e0d8e
PS2, Line 13: #define EXT_TSEG_MBYTES 0x50
Maybe add the comment about being QEMU specific here, otherwise somebody
might "clean it up" by moving it to the header file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c86ac0bb05563dee111b9b4a4a71c1c31198acd
Gerrit-Change-Number: 50024
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 21:54:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment