Arthur Heymans has uploaded this change for review.

View Change

mb/*/*: Don't guard serial setup

Even without using the console it might be useful to set up the
console regardless, for instance with VBOOT or normal/fallback setups.
This will be more meaningful once C_ENVIRONMENT_BOOTBLOCK is
implemented.

Change-Id: Ieca2ec1e376cdb26d76222126307fe016572d9d7
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/mainboard/hp/compaq_8200_elite_sff/romstage.c
M src/mainboard/hp/z220_sff_workstation/romstage.c
M src/mainboard/ocp/wedge100s/romstage.c
3 files changed, 3 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/36603/1
diff --git a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c
index 258eac7..b0dd962 100644
--- a/src/mainboard/hp/compaq_8200_elite_sff/romstage.c
+++ b/src/mainboard/hp/compaq_8200_elite_sff/romstage.c
@@ -58,8 +58,7 @@

void mainboard_config_superio(void)
{
- if (CONFIG(CONSOLE_SERIAL))
- nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
+ nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
}

void mainboard_get_spd(spd_raw_data *spd, bool id_only)
diff --git a/src/mainboard/hp/z220_sff_workstation/romstage.c b/src/mainboard/hp/z220_sff_workstation/romstage.c
index 6c139ed..e07007c 100644
--- a/src/mainboard/hp/z220_sff_workstation/romstage.c
+++ b/src/mainboard/hp/z220_sff_workstation/romstage.c
@@ -58,8 +58,7 @@

void mainboard_config_superio(void)
{
- if (CONFIG(CONSOLE_SERIAL))
- nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
+ nuvoton_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
}

void mainboard_get_spd(spd_raw_data *spd, bool id_only)
diff --git a/src/mainboard/ocp/wedge100s/romstage.c b/src/mainboard/ocp/wedge100s/romstage.c
index 108d7a1..c0d2ca0 100644
--- a/src/mainboard/ocp/wedge100s/romstage.c
+++ b/src/mainboard/ocp/wedge100s/romstage.c
@@ -42,8 +42,7 @@
pci_write_config32(PCI_DEV(0x0, LPC_DEV, LPC_FUNC), LPC_GEN2_DEC,
(0 << 16) | ALIGN_DOWN(0xca2, 4) | 1);

- if (CONFIG(CONSOLE_SERIAL))
- ite_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);
+ ite_enable_serial(SERIAL_DEV, CONFIG_TTYS0_BASE);


/*

To view, visit change 36603. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieca2ec1e376cdb26d76222126307fe016572d9d7
Gerrit-Change-Number: 36603
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-MessageType: newchange