View Change

2 comments:

• File src/mainboard/google/dedede/romstage.c:

  • Patch Set #17, Line 29:

    nit: can we remove the extra line.

• File src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h:

  • Patch Set #17, Line 20:

    
    /* Memory configuration board straps */
    #define GPIO_MEM_CONFIG_0	GPP_C0
    #define GPIO_MEM_CONFIG_1	GPP_C3
    #define GPIO_MEM_CONFIG_2	GPP_C4
    #define GPIO_MEM_CONFIG_3	GPP_C5
    

    can you please add below entry in gpio.c(early gpio table)

    	/* C0  : RAM_STRAP_0 */
    	PAD_CFG_GPI(GPP_C0, NONE, DEEP),
    	/* C3  : RAM_STRAP_1 */
    	PAD_CFG_GPI(GPP_C3, NONE, DEEP),
    	/* C4  : RAM_STRAP_2 */
    	PAD_CFG_GPI(GPP_C4, NONE, DEEP),
    	/* C5  : RAM_STRAP_3 */
    	PAD_CFG_GPI(GPP_C5, NONE, DEEP),

To view, visit change 39136. To unsubscribe, or for help writing mail filters, visit settings.