Maxim Polyakov has uploaded this change for review.
soc/intel/common/gpio_defs: Remove incorrent GPO macro
GPIO Driver mode is used for configuration interrupt routing for
external devices through GPI. But there is no point in configuring
this for GPO. For this reason, this patch removes the
PAD_CFG_GPO_GPIO_DRIVER macro as it is not correct. This has also
been removed from the pad configuration in the follow boards and
this patch should be added after:
[1] Change-Id: I5aed5769600bb9c442ad13a2efbcf9d5fd8da537
[2] Change-Id: Iac7d674e79e0caee467fc087e6d36192e84a12d8
[3] Change-Id: Icbbc644adda0dde768171e9581ae345cb9750eea
[4] Change-Id: I406a08e526a6c655f38e4c0a355957c98e93881c
Change-Id: I74c318897647836f4604a937543254f44b470433
Signed-off-by: Maxim Polyakov <max.senia.poliak@gmail.com>
---
M Documentation/getting_started/gpio.md
M src/soc/intel/common/block/include/intelblocks/gpio_defs.h
2 files changed, 0 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/44471/1
diff --git a/Documentation/getting_started/gpio.md b/Documentation/getting_started/gpio.md
index 13aeed5..339289b 100644
--- a/Documentation/getting_started/gpio.md
+++ b/Documentation/getting_started/gpio.md
@@ -92,8 +92,6 @@
#define PAD_CFG_GPO(pad, val, rst)
/* General purpose output, with termination specified */
#define PAD_CFG_TERM_GPO(pad, val, pull, rst)
- /* General purpose output, no pullup/down. */
- #define PAD_CFG_GPO_GPIO_DRIVER(pad, val, rst, pull)
/* General purpose input */
#define PAD_CFG_GPI(pad, pull, rst)
```
diff --git a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
index 3d3c831..4dcf04c 100644
--- a/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
+++ b/src/soc/intel/common/block/include/intelblocks/gpio_defs.h
@@ -229,14 +229,6 @@
PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | !!val, \
PAD_PULL(pull) | PAD_IOSSTATE(TxLASTRxE))
-/* General purpose output, no pullup/down. */
-#define PAD_CFG_GPO_GPIO_DRIVER(pad, val, rst, pull) \
- _PAD_CFG_STRUCT(pad, \
- PAD_FUNC(GPIO) | PAD_RESET(rst) | \
- PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | !!val, \
- PAD_PULL(pull) | PAD_IOSSTATE(TxLASTRxE) | \
- PAD_CFG_OWN_GPIO(DRIVER))
-
/* General purpose output. */
#define PAD_CFG_GPO_IOSSTATE_IOSTERM(pad, val, rst, pull, iosstate, ioterm) \
_PAD_CFG_STRUCT(pad, \
To view, visit change 44471. To unsubscribe, or for help writing mail filters, visit settings.