12 comments:
File payloads/libpayload/include/riscv/arch/asm.h:
Patch Set #1, Line 14: #define ALIGN .align 2
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 16: #define ENDPROC(name) \
Macros with multiple statements should be enclosed in a do - while loop
Patch Set #1, Line 17: .type name, %function; \
need consistent spacing around '%' (ctx:WxV)
Patch Set #1, Line 20: #define ENTRY(name) \
Macros with multiple statements should be enclosed in a do - while loop
Patch Set #1, Line 21: .section .text.name, "ax", %progbits; \
need consistent spacing around '%' (ctx:WxV)
Patch Set #1, Line 24: name:
labels should not be indented
Patch Set #1, Line 26: #define END(name) \
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 27: .size name, .-name
space required before that '-' (ctx:VxV)
File payloads/libpayload/include/riscv/arch/barrier.h:
Patch Set #1, Line 57: #define mb()
memory barrier without comment
Patch Set #1, Line 58: #define rmb()
memory barrier without comment
Patch Set #1, Line 59: #define wmb()
memory barrier without comment
File payloads/libpayload/include/riscv/arch/cache.h:
void function return statements are not generally useful
To view, visit change 31356. To unsubscribe, or for help writing mail filters, visit settings.