7 comments:
File src/mainboard/google/kukui/mainboard.c:
Patch Set #17, Line 161: SPM initial fail!!!
SPM initialization failed, suspend/resume may fail.
File src/soc/mediatek/mt8183/Makefile.inc:
Patch Set #17, Line 72: 3rdparty/blobs/soc/mediatek/mt8183/pcm_allinone_lp4_3200.bin
let's try to refactor this with the sspm one.
MT8183_BLOB_DIR := 3rdparty/blobs/src/mediatek/mt8183
...
sspm.bin-file $(MT8183_BLOB_DIR)/sspm.bin
...
pcm_allinone_... := $(MT8183_BLOB_DIR)/pcm_allinone_lp4_3733.bin
File src/soc/mediatek/mt8183/spm.c:
write32(&mtk_spm->spare_ack_mask,
(read32(&mtk_spm->spare_ack_mask) & ~SPARE_ACK_MASK_B_BIT1) |
SPARE_ACK_MASK_B_BIT0);
Is this equivalent to:
clrsetbits32(read32(&mtk_spm->spare_ack_mask),
SPARE_ACK_MASK_B_BIT1,
SPARE_ACK_MASK_B_BIT0);
Patch Set #17, Line 88: write32
setbits32 ?
Patch Set #17, Line 130: read32(&mtk_spm->pcm_reg0_data)
wrong indent - this should be aligned to (
Patch Set #17, Line 135: write32
clrsetbits32?
Patch Set #17, Line 309: while
should we do a wait_us or wait_ms here?
To view, visit change 34545. To unsubscribe, or for help writing mail filters, visit settings.