1 comment:
File src/mainboard/google/zork/variants/baseboard/include/baseboard/variants.h:
Patch Set #1, Line 37: fpmcu_needs_delay
A thought: Instead of having a function call back, does it make sense to have a Kconfig here like https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/coreboot/src/mainboard/google/zork/Kconfig;l=200.
and these can be used directly in gpio_baseboard_trembyle.c. It is one less variant function to care about and newer boards using newer schematics don't need to worry about this at all. (I know weak function provides the same functionality, but having the Kconfig allows easier audit to decide when to drop the support for these quirks).
To view, visit change 47369. To unsubscribe, or for help writing mail filters, visit settings.