Alex Thiessen has uploaded this change for review. ( https://review.coreboot.org/23093
Change subject: util/gitconfig: Don't require `remake` ......................................................................
util/gitconfig: Don't require `remake`
As the code was moved from the Makefile.inc to a separate file, `$(MAKE)` was replaced by `remake`, introducing dependency on this tool which is basically a `make` with debugging capabilities.
Many developers don't have `remake` installed, leading to pre-commit hooks being not executed properly. Apparently this was an unintentional change in commit 9ab8ae6a (util/gitconfig: Make gitconfig a bash script) and so it is reverted.
Change-Id: Ic5ee9a0770e173ef0ffacc773c7f30f38cf478e9 Signed-off-by: Alex Thiessen alex.thiessen.de+coreboot@gmail.com --- M util/gitconfig/gitconfig.sh 1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/23093/1
diff --git a/util/gitconfig/gitconfig.sh b/util/gitconfig/gitconfig.sh index 5f91a69..b80a2e9 100755 --- a/util/gitconfig/gitconfig.sh +++ b/util/gitconfig/gitconfig.sh @@ -7,7 +7,8 @@ for hook in commit-msg pre-commit ; do if [ util/gitconfig/$hook -nt .git/hooks/$hook ] || \ [ ! -x .git/hooks/$hook ]; then - sed -e "s,%MAKE%,remake,g" util/gitconfig/$hook > .git/hooks/$hook + sed -e "s,%MAKE%,$(MAKE),g" util/gitconfig/$hook \ + > .git/hooks/$hook chmod +x .git/hooks/$hook fi done