Patch Set 3:

Patch Set 3:

Patch Set 3:

Patch Set 3: Code-Review+1

Is there a gpio to detect the Thunderbolt controller at runtime?

The controller hotplugs itself to the chipset when a downstream device is hotplugged into it,

You mean a gpio to detect the TB controller hidden from the pci-e bus due to absence of downstream devices?

Yes. Everything else has one detection gpio: Bluetooth, wwan, dGPU, ...

If there is one detection gpio for the TB controller, how can I mark it? The gpio.c generated by autoport on t430s with TB controller running vendor firmware do have meaningful differences with the gpio.c in coreboot's tree.

Check schematics or compare inteltool output between devices that have a TB and one that doesn't have one.
If none is possible, just mark it with a TODO.

View Change

To view, visit change 31631. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f41db100f398069e50e2da8a378b3a8d1c84bf
Gerrit-Change-Number: 31631
Gerrit-PatchSet: 3
Gerrit-Owner: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Bill XIE <persmule@hardenedlinux.org>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 25 Aug 2019 08:14:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment