Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47072 )
Change subject: cpu/x86/smm_loaderv2: Use the smm_loader_params stack
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
File src/cpu/x86/smm/smm_module_loaderv2.c:
https://review.coreboot.org/c/coreboot/+/47072/comment/4c6fe1cc_0b90f4fa
PS8, Line 251: if (params->stack_top != NULL)
I don't end up using this...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47072
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I125d3aa6526c923e154c41e2d586557c7d8f56c3
Gerrit-Change-Number: 47072
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 02 Mar 2021 15:27:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment