[coreboot-gerrit] Change in coreboot[master]: util/cbfstool: Introduce concept of mmap_window

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47831 )

Change subject: util/cbfstool: Introduce concept of mmap_window
......................................................................

Patch Set 16:

(2 comments)

Patchset:

PS16:
> Kyösti found the error: […]

Sorry about the breakage, Paul. Does this help fix the problem:

```

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index 57c9e5117f..3329719a26 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -255,7 +255,8 @@ static int find_mmap_window(enum mmap_addr_type addr_type, unsigned int addr)
                else
                        reg = &mmap_window_table[i].flash_space;

-               if (region_offset(reg) <= addr && region_end(reg) >= addr)
+               if (region_offset(reg) <= addr &&
+                   ((uint64_t)region_offset(reg) + (uint64_t)region_sz(reg) - 1) >= addr)
                        return i;
        }
```

File util/cbfstool/cbfstool.c:

https://review.coreboot.org/c/coreboot/+/47831/comment/98a8537f_4a7ad09e 
PS16, Line 197: >=
> static inline size_t region_end(const struct region *r) […]

Yeah, both the points you pointed out are problems and need to be fixed:

* region_end() is non-inclusive
* check doesn't work for 32-bit user space