Whoops, yeah, not sure how we all missed that...
4 comments:
File src/security/vboot/ec_sync.c:
Patch Set #1, Line 69: vboot_reboot();
This seems a bit odd for error handling? If you do want to reboot, you should at least vb2api_fail() first so that we'll drop into recovery mode. Otherwise, I think a die() would also be fine here (it shouldn't really happen).
Patch Set #1, Line 71: poweroff();
poweroff() is not available on all coreboot platforms, so putting this here would prevent us from using it more widely. There's no need to do it anyway, you can just halt() and wait for the EC to reboot us.
Patch Set #1, Line 86: poweroff();
This has the same problem with poweroff(). Luckily, I don't think the EC sync code needs it?
Patch Set #1, Line 95: if (retval != VB2_SUCCESS) {
nit: maybe just put a
case VB2_SUCCESS:
break;
at the top?
To view, visit change 37562. To unsubscribe, or for help writing mail filters, visit settings.