3 comments:
File src/soc/intel/common/block/include/intelblocks/lpss.h:
nit: All the soc specific functions have the format with soc_*. Prefer to maintain that format. Again my personal opinion.
File src/soc/intel/common/block/lpss/lpss.c:
Patch Set #4, Line 83: static const int *lpss_devices;
Please leave a blank line between declaration block and function body.
Patch Set #4, Line 87: dev->path.pci.devfn
It is also better to ensure that the device path is a PCI type in addition to checking the devfn.
To view, visit change 34137. To unsubscribe, or for help writing mail filters, visit settings.