Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32142 )
Change subject: ec/google/chromeec: Remove redundant use of ACPI offset operator
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl
File src/ec/google/chromeec/acpi/ec.asl:
https://review.coreboot.org/#/c/32142/2/src/ec/google/chromeec/acpi/ec.asl@a...
PS2, Line 90:
As Martin indicated, those are just remarks and do not fail compilation.
I wonder if we should push for some kind of location assert to make the distinction explicit?
That would be ideal!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32142
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iedf67f1caafa9627491e8b8f91be69b551d07ae8
Gerrit-Change-Number: 32142
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Wed, 03 Apr 2019 04:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment