View Change

13 comments:

• File src/northbridge/intel/x4x/raminit.h:

  • Patch Set #2, Line 27: #define IF_DIMM_POPULATED(dimms, idx) if (dimms[idx].card_type != RAW_CARD_UNPOPULATED)

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Patch Set #2, Line 39: #define FOR_EACH_POPULATED_DIMM(dimms, idx) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 43: #define FOR_EACH_POPULATED_DIMM_IN_CHANNEL(dimms, ch, idx) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 51: #define IF_CHANNEL_POPULATED(dimms, idx) \

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Patch Set #2, Line 56: #define FOR_EACH_POPULATED_CHANNEL(dimms, idx) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 62: ((dimms[(ch<<1) + 1].card_type != RAW_CARD_UNPOPULATED) && ((r) >= 2) && ((r) < (dimms[(ch<<1) + 1].ranks + 2))))

    line over 96 characters

  • Patch Set #2, Line 63: #define IF_RANK_POPULATED(dimms, ch, r) \

    Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects

  • Patch Set #2, Line 70: #define FOR_EACH_POPULATED_RANK_IN_CHANNEL(dimms, ch, r) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 72: #define FOR_EACH_RANK(ch, r) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 74: #define FOR_EACH_POPULATED_RANK(dimms, ch, r) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 78: #define FOR_EACH_POPULATED_CHANNEL_AND_BYTELANE(dimms, ch, l) \

    Macros with complex values should be enclosed in parentheses

  • Patch Set #2, Line 79: FOR_EACH_POPULATED_CHANNEL (dimms, ch) FOR_EACH_BYTELANE(l)

    space prohibited between function name and open parenthesis '('

  • Patch Set #2, Line 213: void do_raminit(struct sysinfo *, int fast_boot);

    function definition argument 'struct sysinfo *' should also have an identifier name

To view, visit change 45424. To unsubscribe, or for help writing mail filters, visit settings.