Thanks for taking care of this.

View Change

3 comments:

• File src/soc/intel/skylake/Kconfig:

  • Patch Set #1, Line 263: default 3

    Would this ever be something else? If not it could be a constant
    in the code.

• File src/soc/intel/skylake/romstage/romstage_fsp20.c:

  • Patch Set #1, Line 253: m_t_cfg->Peg2Gen3EqPh2Enable = config->PegGen3EqPh2Enable[2];

    What about `PegGen3EqPh3Method`? I wouldn't mind hard-
    coding it to `0` here. That's still better than not knowing
    what it's set to.

  • Patch Set #1, Line 254: }

    Until somebody tells me something else, I consider every
    setting that differs from "Auto" as a workaround for a bug.
    So I wonder, why would we ever want the same overrides on
    all three ports?

    Please elaborate what settings you need and what the defaults
    in the binary are. I would prefer as many reasonable hard-coded
    defaults as possible. Only when we really need a non-default,
    I'd add settings to `chip.h`.

To view, visit change 32045. To unsubscribe, or for help writing mail filters, visit settings.