HAOUAS Elyes has uploaded this change for review.

View Change

soc/mediatek/mt8173/i2c.c: Remove variable set but not used

Change-Id: I52d841aed31ce6d447280c75c1a1e7a08d8e0ca2
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
---
M src/soc/mediatek/mt8173/i2c.c
1 file changed, 15 insertions(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/33062/1
diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c
index 3395539..c09eeb1 100644
--- a/src/soc/mediatek/mt8173/i2c.c
+++ b/src/soc/mediatek/mt8173/i2c.c
@@ -111,30 +111,26 @@

static inline void mtk_i2c_dump_info(uint8_t bus)
{
- struct mt8173_i2c_regs *regs;
-
- regs = i2c[bus].i2c_regs;
-
I2CLOG("I2C register:\nSLAVE_ADDR %x\nINTR_MASK %x\nINTR_STAT %x\n"
"CONTROL %x\nTRANSFER_LEN %x\nTRANSAC_LEN %x\nDELAY_LEN %x\n"
"TIMING %x\nSTART %x\nFIFO_STAT %x\nIO_CONFIG %x\nHS %x\n"
"DEBUGSTAT %x\nEXT_CONF %x\n",
- (read32(&regs->salve_addr)),
- (read32(&regs->intr_mask)),
- (read32(&regs->intr_stat)),
- (read32(&regs->control)),
- (read32(&regs->transfer_len)),
- (read32(&regs->transac_len)),
- (read32(&regs->delay_len)),
- (read32(&regs->timing)),
- (read32(&regs->start)),
- (read32(&regs->fifo_stat)),
- (read32(&regs->io_config)),
- (read32(&regs->hs)),
- (read32(&regs->debug_stat)),
- (read32(&regs->ext_conf)));
+ (read32(&i2c[bus].i2c_regs->salve_addr)),
+ (read32(&i2c[bus].i2c_regs->intr_mask)),
+ (read32(&i2c[bus].i2c_regs->intr_stat)),
+ (read32(&i2c[bus].i2c_regs->control)),
+ (read32(&i2c[bus].i2c_regs->transfer_len)),
+ (read32(&i2c[bus].i2c_regs->transac_len)),
+ (read32(&i2c[bus].i2c_regs->delay_len)),
+ (read32(&i2c[bus].i2c_regs->timing)),
+ (read32(&i2c[bus].i2c_regs->start)),
+ (read32(&i2c[bus].i2c_regs->fifo_stat)),
+ (read32(&i2c[bus].i2c_regs->io_config)),
+ (read32(&i2c[bus].i2c_regs->hs)),
+ (read32(&i2c[bus].i2c_regs->debug_stat)),
+ (read32(&i2c[bus].i2c_regs->ext_conf)));

- I2CLOG("addr address %x\n", (uint32_t)regs);
+ I2CLOG("addr address %x\n", (uint32_t)i2c[bus].i2c_regs);
}

static uint32_t mtk_i2c_transfer(uint8_t bus, struct i2c_msg *seg,

To view, visit change 33062. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I52d841aed31ce6d447280c75c1a1e7a08d8e0ca2
Gerrit-Change-Number: 33062
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-MessageType: newchange