Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79016?usp=email )
Change subject: soc/amd/common: Move PCIe CLKREQ programming under fsp
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
most of that code is fsp-agnostic; the main thing that's not fsp-agnostic is how that code gets the […]
while this code isn't really fsp-specific, this will likely only be needed in the fsp use case.
while i push for getting more things done in open source code, moving the gpp clk configuration out of fsp was probably not worth the trouble it has caused so far, since this is quite intertwined with the dxio init code. the function that gets moved here, fixes up the config in the devicetree so that it'll be valid for the dxio configuration
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79016?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I87b53d092ddc367b134c25949f9da7670a6a1d88
Gerrit-Change-Number: 79016
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 01 Dec 2023 16:29:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment