7 comments:
Set the controller state to D0 during the GSPI sequence,
this ensures the controller is up and active.
Please use the full text width.
Done
File src/soc/intel/common/block/gspi/gspi.c:
Patch Set #1, Line 179: lpss_set_power_state(tree_dev, STATE_D0);
please, no spaces at the start of a line
Done
Patch Set #1, Line 179: lpss_set_power_state(tree_dev, STATE_D0)
gspi_early_bar_init() is getting called from bootblock/pch. […]
Done
Done
Done
Patch Set #1, Line 179: lpss_set_power_state(tree_dev, STATE_D0);
code indent should use tabs where possible
Done
Patch Set #1, Line 458: lpss_set_power_state((struct device*) dev, STATE_D0);
Done
Done
File src/soc/intel/common/block/gspi/gspi.c:
devfn = gspi_soc_bus_to_devfn(dev->bus);
device = pcidev_path_on_root(devfn);
/* Ensure controller is in D0 state */
lpss_set_power_state(device, STATE_D0);
Thank you. Yes, I am considering doing it after the reset i.e line 480. […]
Done
To view, visit change 34449. To unsubscribe, or for help writing mail filters, visit settings.