Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35924 )
Change subject: Revert "soc/intel/cannonlake: Remove DMA support for PTT"
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35924/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35924/2//COMMIT_MSG@11
PS2, Line 11: Reason for revert: Breaks boot on Whiskey Lake-U System76 boards
Why? What is the interaction? An FSP default setting for that board? Soft strap configuration? Fusing?
without the mem allocated for PTT removed from reserved size, size mismatch occurs and boot halts
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35924
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib82f02c4a2b1cd2dbf95d4ca4a9edd314e78edd2
Gerrit-Change-Number: 35924
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Jeremy Soller
jackpot51@gmail.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 09 Oct 2019 19:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment