[coreboot-gerrit] [XS] Change in coreboot[main]: mb/intel: Enable TPM2 on Gen6 Xeon-SP mainboards

[Shuo Liu (Code Review)]

Attention is currently required from: Johnny Lin.

Hello Johnny Lin,

I'd like you to do a code review.
Please visit

https://review.coreboot.org/c/coreboot/+/85291?usp=email

to review the following change.

Change subject: mb/intel: Enable TPM2 on Gen6 Xeon-SP mainboards
......................................................................

mb/intel: Enable TPM2 on Gen6 Xeon-SP mainboards

IBL provides memory-mapped TPM and will not react on 0xc31 for
TPM access, set the port as 0x0.

Tested=On Avenuecity CRB, /dev/tpm0 is created under Linux, TPM
SSDT and TPM2 table will be presented

Change-Id: I95f85f6a886a7e6ba71b23c9f1789d8f3457864b
Signed-off-by: Johnny Lin 
---
M src/mainboard/intel/avenuecity_crb/Kconfig
M src/mainboard/intel/avenuecity_crb/devicetree.cb
M src/mainboard/intel/beechnutcity_crb/Kconfig
M src/mainboard/intel/beechnutcity_crb/devicetree.cb
4 files changed, 8 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/85291/1

diff --git a/src/mainboard/intel/avenuecity_crb/Kconfig b/src/mainboard/intel/avenuecity_crb/Kconfig
index fff244e..45e3c70 100644
--- a/src/mainboard/intel/avenuecity_crb/Kconfig
+++ b/src/mainboard/intel/avenuecity_crb/Kconfig
@@ -12,6 +12,7 @@
    select IPMI_KCS_ROMSTAGE
    select VPD
    select OCP_VPD
+	select MAINBOARD_HAS_TPM2
    select MEMORY_MAPPED_TPM

config CARDBUS_PLUGIN_SUPPORT
diff --git a/src/mainboard/intel/avenuecity_crb/devicetree.cb b/src/mainboard/intel/avenuecity_crb/devicetree.cb
index 0754916..01aa5d6 100644
--- a/src/mainboard/intel/avenuecity_crb/devicetree.cb
+++ b/src/mainboard/intel/avenuecity_crb/devicetree.cb
@@ -32,6 +32,9 @@
    			register "wait_for_bmc" = "1"
    			register "bmc_boot_timeout" = "60"
    		end
+			chip drivers/pc80/tpm
+				device pnp 0 on end # TPM
+			end
    	end
    end
 end
diff --git a/src/mainboard/intel/beechnutcity_crb/Kconfig b/src/mainboard/intel/beechnutcity_crb/Kconfig
index 3c2f02a..22771c0 100644
--- a/src/mainboard/intel/beechnutcity_crb/Kconfig
+++ b/src/mainboard/intel/beechnutcity_crb/Kconfig
@@ -12,6 +12,7 @@
    select IPMI_KCS_ROMSTAGE
    select VPD
    select OCP_VPD
+	select MAINBOARD_HAS_TPM2
    select MEMORY_MAPPED_TPM

config CARDBUS_PLUGIN_SUPPORT
diff --git a/src/mainboard/intel/beechnutcity_crb/devicetree.cb b/src/mainboard/intel/beechnutcity_crb/devicetree.cb
index 0754916..01aa5d6 100644
--- a/src/mainboard/intel/beechnutcity_crb/devicetree.cb
+++ b/src/mainboard/intel/beechnutcity_crb/devicetree.cb
@@ -32,6 +32,9 @@
    			register "wait_for_bmc" = "1"
    			register "bmc_boot_timeout" = "60"
    		end
+			chip drivers/pc80/tpm
+				device pnp 0 on end # TPM
+			end
    	end
    end
 end