6 comments:
File src/soc/amd/picasso/Makefile.inc:
Why the magic number?
File src/soc/amd/picasso/bootblock/bootblock.c:
Patch Set #7, Line 34: sb_reset_i2c_slaves();
How is this expected to make a difference for consoles? Why is this done […]
+1. I think we can remove this here. fch_pre_init will take care of it.
We do want the pins to float: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/coreboot/src/soc/amd/picasso/i2c.c;l=155
Patch Set #7, Line 41: Family_Model
In its encoded form, it's usually called cpuid signature. You can decode […]
This was the same format that was followed on stoney: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/coreboot/src/soc/amd/stoneyridge/bootblock/bootblock.c;l=110
Patch Set #7, Line 44: i2c_soc_early_init();
I'm also rather new to AMD. […]
I think sb_ and fch_ are synonyms. As for why i2c has _soc_ in the name, I don't know. The I2C block is under the FCH.
File src/soc/amd/picasso/bootblock/bootblock.c:
Patch Set #9, Line 7: cpu/amd/msr.h
Maybe just arch/cpu.h?
Patch Set #9, Line 8: #include <cpu/x86/mtrr.h>
Is this one used?
To view, visit change 37490. To unsubscribe, or for help writing mail filters, visit settings.