The resulting assembly is definitely not the same... You'd want to test this on hardware
Patch set 1:Code-Review -1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: Remove variable set but not used
The whole purpose of this variable is to sample the strobe so it is normal that it does not get used, hence the use of the volatile keyword. Also the resulting assembly is different with this change.
To view, visit change 32948. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d6593e283f0a9e6603e19ccfda116f3b145e52
Gerrit-Change-Number: 32948
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Thu, 23 May 2019 10:10:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment