Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/68199 )
Change subject: src/acpi: Clean up includes ......................................................................
src/acpi: Clean up includes
Signed-off-by: Elyes Haouas ehaouas@noos.fr Change-Id: Ia0ba40a671dfb804231419450036c15f480f1749 --- M src/acpi/acpi_pm.c M src/acpi/acpigen.c M src/acpi/acpigen_dsm.c M src/acpi/acpigen_ps2_keybd.c M src/acpi/device.c M src/acpi/sata.c 6 files changed, 21 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/68199/1
diff --git a/src/acpi/acpi_pm.c b/src/acpi/acpi_pm.c index 40a3fbd..627ab3e0 100644 --- a/src/acpi/acpi_pm.c +++ b/src/acpi/acpi_pm.c @@ -6,6 +6,7 @@ #include <cbmem.h> #include <console/console.h> #include <smbios.h> +#include <stdint.h>
static const char *pm_fetch_failure_msg[PS_CLAIMER_MAX] = { [PS_CLAIMER_ELOG] = "no event recorded in ELOG.", diff --git a/src/acpi/acpigen.c b/src/acpi/acpigen.c index acef34d..466253f 100644 --- a/src/acpi/acpigen.c +++ b/src/acpi/acpigen.c @@ -10,14 +10,15 @@
#define ACPIGEN_MAXLEN 0xfffff
-#include <lib.h> -#include <string.h> +#include <acpi/acpi.h> #include <acpi/acpigen.h> #include <assert.h> #include <commonlib/helpers.h> #include <console/console.h> #include <device/device.h> #include <device/soundwire.h> +#include <lib.h> +#include <string.h> #include <types.h>
static char *gencurrent; diff --git a/src/acpi/acpigen_dsm.c b/src/acpi/acpigen_dsm.c index 734fbd5..1989696 100644 --- a/src/acpi/acpigen_dsm.c +++ b/src/acpi/acpigen_dsm.c @@ -2,6 +2,7 @@
#include <acpi/acpigen.h> #include <acpi/acpigen_dsm.h> +#include <commonlib/bsd/helpers.h>
/* ------------------- I2C HID DSM ---------------------------- */
diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 7928dad..98c4baa 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -4,8 +4,7 @@ #include <acpi/acpigen_ps2_keybd.h> #include <console/console.h> #include <input-event-codes.h> -#include <stdbool.h> -#include <stdint.h> +#include <types.h>
#define KEYMAP(scancode, keycode) (((uint32_t)(scancode) << 16) | (keycode & 0xFFFF)) #define SCANCODE(keymap) ((keymap >> 16) & 0xFFFF) diff --git a/src/acpi/device.c b/src/acpi/device.c index 2b085b6..0c43c0d 100644 --- a/src/acpi/device.c +++ b/src/acpi/device.c @@ -1,19 +1,17 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <assert.h> -#include <string.h> #include <acpi/acpi.h> #include <acpi/acpi_device.h> #include <acpi/acpigen.h> #include <acpi/acpigen_pci.h> +#include <assert.h> +#include <commonlib/bsd/helpers.h> +#include <crc_byte.h> #include <device/device.h> #include <device/path.h> #include <stdlib.h> +#include <string.h> #include <types.h> -#include <crc_byte.h> - -#if CONFIG(GENERIC_GPIO_LIB) -#include <gpio.h> #endif
#define ACPI_DP_UUID "daffd814-6eba-4d8c-8a91-bc9bbf4aa301" diff --git a/src/acpi/sata.c b/src/acpi/sata.c index 282d366..fc7ced0 100644 --- a/src/acpi/sata.c +++ b/src/acpi/sata.c @@ -2,6 +2,7 @@
#include <acpi/acpigen.h> #include <acpi/acpi_sata.h> +#include <stdint.h>
/* e.g. * generate_sata_ssdt_ports("_SB.PCI0.SATA", 0x3);