I don't think this is something that many people will be happy about either. These tools aren't perfect and sometimes you *want* to ignore style in specific cases. Looks to me like this isn't actually doing anything right now due to the lack of a scope file(?), but if you plan to add that later, it's probably going to bring trouble as well.

View Change

1 comment:

To view, visit change 31654. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e9a32eb9281b5cb0b45506a206500fd1d315372
Gerrit-Change-Number: 31654
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Julius Werner <jwerner@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 11 Mar 2019 20:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment