
Attention is currently required from: Hung-Te Lin, Jason Glenesk, Raul Rangel, Marshall Dawson, Christian Walter, Julius Werner, Andrey Petrov, Fred Reitberger, Yu-Ping Wu, Felix Held. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63375 ) Change subject: [RFC] CBMEM: Have INIT_HOOKS in every stage ...................................................................... Patch Set 1: (2 comments) File src/include/cbmem.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145408): https://review.coreboot.org/c/coreboot/+/63375/comment/0e68ab48_00b52262 PS1, Line 109: #define CBMEM_INIT_HOOK(init_fn_) \ macros should not use a trailing semicolon Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-145408): https://review.coreboot.org/c/coreboot/+/63375/comment/990ba98d_471227d1 PS1, Line 115: #define CBMEM_INIT_HOOK_EARLY(init_fn_) \ macros should not use a trailing semicolon -- To view, visit https://review.coreboot.org/c/coreboot/+/63375 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie24bf4e818ca69f539196c3a814f3c52d4103d7e Gerrit-Change-Number: 63375 Gerrit-PatchSet: 1 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org> Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Reviewer: Julius Werner <jwerner@chromium.org> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com> Gerrit-CC: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte@chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com> Gerrit-Attention: Raul Rangel <rrangel@chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com> Gerrit-Attention: Christian Walter <christian.walter@9elements.com> Gerrit-Attention: Julius Werner <jwerner@chromium.org> Gerrit-Attention: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred@gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso@google.com> Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de> Gerrit-Comment-Date: Tue, 05 Apr 2022 17:53:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment