Patch Set 3:

Patch Set 3:

Patch Set 3:

May I consult what is bad thing for enabling eMMC and SSD controller always? Thanks.

Dear Marco, if enable both MDIO and PCI-E controller, DUT may encounter interrupt storm since have relevant GPIOs(MDIO or PCI-E) not be closed.

Then for the discussion of SKU ID 255 to support both storage, we will have this interrupt storm issue? Where is the interrupt storm came from? Sorry, if you discussed it then please just point me to the issue, thanks.

I am actually interested in knowing the answer to this. What is the interrupt storm that you are referring to here. I was under the impression that the controllers are being disabled for power or S0ix related reasons. I would really like to see an analysis of why GPIOs/controllers need to be configured differently between eMMC and SSD.

View Change

To view, visit change 35204. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 4
Gerrit-Owner: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Peichao Li <peichao.wang@bitland.corp-partner.google.com>
Gerrit-Reviewer: Philip Chen <philipchen@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-CC: Marco Chen <marcochen@google.com>
Gerrit-Comment-Date: Thu, 05 Sep 2019 02:57:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment