529 comments:
File src/ec/hp/it8987e/acpi/battery.asl:
trailing whitespace
Patch Set #1, Line 29: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 30: 0xFFFFFFFF,
trailing whitespace
trailing whitespace
Patch Set #1, Line 32: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 33: 0xFA,
trailing whitespace
Patch Set #1, Line 34: 0x96,
trailing whitespace
Patch Set #1, Line 35: 0x0A,
trailing whitespace
Patch Set #1, Line 36: 0x19,
trailing whitespace
Patch Set #1, Line 37: "BAT0",
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 44: Zero,
trailing whitespace
Patch Set #1, Line 45: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 46: 0xFFFFFFFF,
trailing whitespace
File src/ec/hp/it8987e/acpi/ec.asl:
Patch Set #1, Line 57: SMPR, 8,
trailing whitespace
Patch Set #1, Line 58: SMST, 8,
trailing whitespace
Patch Set #1, Line 59: SMAD, 8,
trailing whitespace
Patch Set #1, Line 60: SMCM, 8,
trailing whitespace
Patch Set #1, Line 61: SMD0, 256,
trailing whitespace
Patch Set #1, Line 62: BCNT, 8,
trailing whitespace
Patch Set #1, Line 63: SMAA, 8,
trailing whitespace
Patch Set #1, Line 64: Offset (0x40),
trailing whitespace
Patch Set #1, Line 65: SW2S, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 67: ACCC, 1,
trailing whitespace
Patch Set #1, Line 68: TRPM, 1,
trailing whitespace
Patch Set #1, Line 69: Offset (0x41),
trailing whitespace
Patch Set #1, Line 70: W7OS, 1,
trailing whitespace
Patch Set #1, Line 71: QWOS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 73: SUSE, 1,
trailing whitespace
Patch Set #1, Line 74: RFLG, 1,
trailing whitespace
Patch Set #1, Line 75: Offset (0x43),
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 78: ACPS, 1,
trailing whitespace
Patch Set #1, Line 79: ACKY, 1,
trailing whitespace
Patch Set #1, Line 80: GFXT, 1,
trailing whitespace
Patch Set #1, Line 81: Offset (0x44),
trailing whitespace
trailing whitespace
Patch Set #1, Line 83: DSMB, 1,
trailing whitespace
Patch Set #1, Line 84: Offset (0x47),
trailing whitespace
Patch Set #1, Line 85: TNT2, 8,
trailing whitespace
Patch Set #1, Line 86: TNT3, 8,
trailing whitespace
Patch Set #1, Line 87: Offset (0x4C),
trailing whitespace
Patch Set #1, Line 88: STRM, 8,
trailing whitespace
Patch Set #1, Line 89: Offset (0x4E),
trailing whitespace
Patch Set #1, Line 90: LIDE, 1,
trailing whitespace
Patch Set #1, Line 91: Offset (0x4F),
trailing whitespace
Patch Set #1, Line 92: ACID, 8,
trailing whitespace
trailing whitespace
Patch Set #1, Line 94: PTHM, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 96: BSEV, 1,
trailing whitespace
Patch Set #1, Line 97: DPTL, 1,
trailing whitespace
Patch Set #1, Line 98: Offset (0x52),
trailing whitespace
Patch Set #1, Line 99: ECLS, 1,
trailing whitespace
Patch Set #1, Line 100: Offset (0x55),
trailing whitespace
Patch Set #1, Line 101: EC45, 8,
trailing whitespace
Patch Set #1, Line 102: Offset (0x58),
trailing whitespace
Patch Set #1, Line 103: RTMP, 8,
trailing whitespace
Patch Set #1, Line 104: TNT1, 8,
trailing whitespace
Patch Set #1, Line 105: Offset (0x5F),
trailing whitespace
trailing whitespace
Patch Set #1, Line 107: Offset (0x61),
trailing whitespace
Patch Set #1, Line 108: SHPM, 8,
trailing whitespace
Patch Set #1, Line 109: Offset (0x67),
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 112: GC6R, 1,
trailing whitespace
Patch Set #1, Line 113: IGC6, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 115: PVSE, 1,
trailing whitespace
Patch Set #1, Line 116: PVSS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 118: PLGS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 120: TPDF, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 122: BCTF, 1,
trailing whitespace
Patch Set #1, Line 123: BMNF, 1,
trailing whitespace
Patch Set #1, Line 124: BTVD, 1,
trailing whitespace
Patch Set #1, Line 125: BF10, 1,
trailing whitespace
Patch Set #1, Line 126: Offset (0x6C),
trailing whitespace
Patch Set #1, Line 127: GWKR, 8,
trailing whitespace
Patch Set #1, Line 128: Offset (0x70),
trailing whitespace
Patch Set #1, Line 129: BADC, 16,
trailing whitespace
Patch Set #1, Line 130: BFCC, 16,
trailing whitespace
Patch Set #1, Line 131: BVLB, 8,
trailing whitespace
Patch Set #1, Line 132: BVHB, 8,
trailing whitespace
Patch Set #1, Line 133: BDVO, 8,
trailing whitespace
Patch Set #1, Line 134: Offset (0x7F),
trailing whitespace
Patch Set #1, Line 135: ECTB, 1,
trailing whitespace
Patch Set #1, Line 136: Offset (0x82),
trailing whitespace
Patch Set #1, Line 137: MBST, 8,
trailing whitespace
Patch Set #1, Line 138: MCUR, 16,
trailing whitespace
Patch Set #1, Line 139: MBRM, 16,
trailing whitespace
Patch Set #1, Line 140: MBCV, 16,
trailing whitespace
Patch Set #1, Line 141: Offset (0x8B),
trailing whitespace
Patch Set #1, Line 142: LEDM, 3,
trailing whitespace
Patch Set #1, Line 143: Offset (0x8D),
trailing whitespace
trailing whitespace
Patch Set #1, Line 145: MBFC, 1,
trailing whitespace
Patch Set #1, Line 146: Offset (0x92),
trailing whitespace
Patch Set #1, Line 147: SPSV, 8,
trailing whitespace
Patch Set #1, Line 148: Offset (0x94),
trailing whitespace
Patch Set #1, Line 149: GSSU, 1,
trailing whitespace
Patch Set #1, Line 150: GSMS, 1,
trailing whitespace
Patch Set #1, Line 151: Offset (0x95),
trailing whitespace
Patch Set #1, Line 152: MMST, 4,
trailing whitespace
Patch Set #1, Line 153: DMST, 4,
trailing whitespace
Patch Set #1, Line 154: Offset (0xA0),
trailing whitespace
Patch Set #1, Line 155: QBHK, 8,
trailing whitespace
Patch Set #1, Line 156: Offset (0xA2),
trailing whitespace
Patch Set #1, Line 157: QBBB, 8,
trailing whitespace
Patch Set #1, Line 158: Offset (0xA4),
trailing whitespace
Patch Set #1, Line 159: MBTS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 161: BACR, 1,
trailing whitespace
Patch Set #1, Line 162: Offset (0xA6),
trailing whitespace
Patch Set #1, Line 163: MBDC, 8,
trailing whitespace
Patch Set #1, Line 164: Offset (0xA8),
trailing whitespace
Patch Set #1, Line 165: ENWD, 1,
trailing whitespace
Patch Set #1, Line 166: TMPR, 1,
trailing whitespace
Patch Set #1, Line 167: Offset (0xAA),
trailing whitespace
trailing whitespace
Patch Set #1, Line 169: SMSZ, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 171: RCDS, 1,
trailing whitespace
Patch Set #1, Line 172: Offset (0xAD),
trailing whitespace
Patch Set #1, Line 173: SADP, 8,
trailing whitespace
Patch Set #1, Line 174: Offset (0xB2),
trailing whitespace
Patch Set #1, Line 175: RPM1, 8,
trailing whitespace
Patch Set #1, Line 176: RPM2, 8,
trailing whitespace
Patch Set #1, Line 177: Offset (0xBA),
trailing whitespace
Patch Set #1, Line 178: CLOW, 8,
trailing whitespace
Patch Set #1, Line 179: CMAX, 8,
trailing whitespace
Patch Set #1, Line 180: Offset (0xC1),
trailing whitespace
Patch Set #1, Line 181: DPPC, 8,
trailing whitespace
Patch Set #1, Line 182: Offset (0xC6),
trailing whitespace
trailing whitespace
Patch Set #1, Line 184: CVTS, 1,
trailing whitespace
Patch Set #1, Line 185: Offset (0xCE),
trailing whitespace
Patch Set #1, Line 186: NVDX, 8,
trailing whitespace
Patch Set #1, Line 187: ECDX, 8,
trailing whitespace
Patch Set #1, Line 188: EBPL, 1,
trailing whitespace
Patch Set #1, Line 189: Offset (0xD2),
trailing whitespace
trailing whitespace
Patch Set #1, Line 191: DLYE, 1,
trailing whitespace
Patch Set #1, Line 192: Offset (0xD4),
trailing whitespace
Patch Set #1, Line 193: PSHD, 8,
trailing whitespace
Patch Set #1, Line 194: PSLD, 8,
trailing whitespace
Patch Set #1, Line 195: DBPL, 8,
trailing whitespace
Patch Set #1, Line 196: STSP, 8,
trailing whitespace
Patch Set #1, Line 197: Offset (0xDA),
trailing whitespace
Patch Set #1, Line 198: PSIN, 8,
trailing whitespace
Patch Set #1, Line 199: PSKB, 1,
trailing whitespace
Patch Set #1, Line 200: PSTP, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 202: PWOL, 1,
trailing whitespace
Patch Set #1, Line 203: RTCE, 1,
trailing whitespace
Patch Set #1, Line 204: Offset (0xE0),
trailing whitespace
Patch Set #1, Line 205: DLYT, 8,
trailing whitespace
Patch Set #1, Line 206: DLY2, 8,
trailing whitespace
Patch Set #1, Line 207: Offset (0xE6),
trailing whitespace
Patch Set #1, Line 208: SFHK, 8,
trailing whitespace
Patch Set #1, Line 209: Offset (0xE9),
trailing whitespace
Patch Set #1, Line 210: DTMT, 8,
trailing whitespace
Patch Set #1, Line 211: PL12, 8,
trailing whitespace
Patch Set #1, Line 212: ETMT, 8,
trailing whitespace
Patch Set #1, Line 213: Offset (0xF2),
trailing whitespace
Patch Set #1, Line 214: ZPDD, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 216: ENPA, 1,
trailing whitespace
Patch Set #1, Line 217: Offset (0xF4),
trailing whitespace
Patch Set #1, Line 218: SFAN, 8,
trailing whitespace
Patch Set #1, Line 219: Offset (0xF9),
trailing whitespace
trailing whitespace
Patch Set #1, Line 707: Offset (0x04),
trailing whitespace
Patch Set #1, Line 713: Offset (0x04),
trailing whitespace
Patch Set #1, Line 719: Offset (0x04),
trailing whitespace
Patch Set #1, Line 725: Offset (0x04),
trailing whitespace
Patch Set #1, Line 731: Offset (0x04),
trailing whitespace
Patch Set #1, Line 737: Offset (0x04),
trailing whitespace
trailing whitespace
trailing whitespace
File src/ec/hp/it8987e/acpi/kb.asl:
trailing whitespace
Patch Set #1, Line 67: 0x3D,
trailing whitespace
Patch Set #1, Line 75: 0x1F,
trailing whitespace
Patch Set #1, Line 105: 0x001E2E4F,
trailing whitespace
Patch Set #1, Line 106: 0x02002E4F,
trailing whitespace
Patch Set #1, Line 136: 0x3D,
trailing whitespace
Patch Set #1, Line 144: 0x1F,
trailing whitespace
File src/ec/hp/it8987e/acpi/tpm.asl:
Patch Set #1, Line 122: Offset (0x04),
trailing whitespace
Patch Set #1, Line 123: LCST, 32,
trailing whitespace
Patch Set #1, Line 124: Offset (0x40),
trailing whitespace
Patch Set #1, Line 125: CREQ, 32,
trailing whitespace
Patch Set #1, Line 126: CSTS, 32,
trailing whitespace
Patch Set #1, Line 127: Offset (0x4C),
trailing whitespace
Patch Set #1, Line 134: Offset (0x04),
trailing whitespace
Patch Set #1, Line 135: HERR, 32,
trailing whitespace
Patch Set #1, Line 136: Offset (0x40),
trailing whitespace
Patch Set #1, Line 137: HCMD, 32,
trailing whitespace
Patch Set #1, Line 170: Offset (0x04),
trailing whitespace
Patch Set #1, Line 171: FERR, 32,
trailing whitespace
Patch Set #1, Line 172: Offset (0x0C),
trailing whitespace
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 276: RQST, 32,
trailing whitespace
Patch Set #1, Line 277: RCNT, 32,
trailing whitespace
Patch Set #1, Line 278: ERRO, 32,
trailing whitespace
Patch Set #1, Line 279: FLAG, 32,
trailing whitespace
Patch Set #1, Line 280: MISC, 32,
trailing whitespace
Patch Set #1, Line 281: OPTN, 32,
trailing whitespace
Patch Set #1, Line 323: Zero,
trailing whitespace
Patch Set #1, Line 337: Zero,
trailing whitespace
Patch Set #1, Line 338: Zero,
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 25: #define EC_IO_HIGH EC_IO + 1
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 26: #define EC_IO_LOW EC_IO + 2
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 27: #define EC_IO_DATA EC_IO + 3
Macros with complex values should be enclosed in parentheses
Patch Set #1, Line 74: if (!output_buffer_full(KBD_STATUS)) return 0;
trailing statements should be on next line
Patch Set #1, Line 80: if (!input_buffer_empty(KBD_STATUS)) return;
trailing statements should be on next line
Patch Set #1, Line 86: if (!input_buffer_empty(KBD_STATUS)) return;
trailing statements should be on next line
Patch Set #1, Line 97: if (!output_buffer_full(EC_SC)) return 0;
trailing statements should be on next line
Patch Set #1, Line 103: if (!input_buffer_empty(EC_SC)) return;
trailing statements should be on next line
Patch Set #1, Line 109: if (!input_buffer_empty(EC_SC)) return;
trailing statements should be on next line
File src/mainboard/hp/spectre_x360_13t_ae000/Kconfig:
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/acpi/battery.asl:
trailing whitespace
Patch Set #1, Line 29: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 30: 0xFFFFFFFF,
trailing whitespace
trailing whitespace
Patch Set #1, Line 32: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 33: 0xFA,
trailing whitespace
Patch Set #1, Line 34: 0x96,
trailing whitespace
Patch Set #1, Line 35: 0x0A,
trailing whitespace
Patch Set #1, Line 36: 0x19,
trailing whitespace
Patch Set #1, Line 37: "BAT0",
trailing whitespace
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 45: 0xFFFFFFFF,
trailing whitespace
Patch Set #1, Line 46: 0xFFFFFFFF,
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/acpi/ec.asl:
Patch Set #1, Line 31: SMPR, 8,
trailing whitespace
Patch Set #1, Line 32: SMST, 8,
trailing whitespace
Patch Set #1, Line 33: SMAD, 8,
trailing whitespace
Patch Set #1, Line 34: SMCM, 8,
trailing whitespace
Patch Set #1, Line 35: SMD0, 256,
trailing whitespace
Patch Set #1, Line 36: BCNT, 8,
trailing whitespace
Patch Set #1, Line 37: SMAA, 8,
trailing whitespace
Patch Set #1, Line 38: Offset (0x40),
trailing whitespace
Patch Set #1, Line 39: SW2S, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 41: ACCC, 1,
trailing whitespace
Patch Set #1, Line 42: TRPM, 1,
trailing whitespace
Patch Set #1, Line 43: Offset (0x41),
trailing whitespace
Patch Set #1, Line 44: W7OS, 1,
trailing whitespace
Patch Set #1, Line 45: QWOS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 47: SUSE, 1,
trailing whitespace
Patch Set #1, Line 48: RFLG, 1,
trailing whitespace
Patch Set #1, Line 49: Offset (0x43),
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 52: ACPS, 1,
trailing whitespace
Patch Set #1, Line 53: ACKY, 1,
trailing whitespace
Patch Set #1, Line 54: GFXT, 1,
trailing whitespace
Patch Set #1, Line 55: Offset (0x44),
trailing whitespace
trailing whitespace
Patch Set #1, Line 57: DSMB, 1,
trailing whitespace
Patch Set #1, Line 58: Offset (0x47),
trailing whitespace
Patch Set #1, Line 59: TNT2, 8,
trailing whitespace
Patch Set #1, Line 60: TNT3, 8,
trailing whitespace
Patch Set #1, Line 61: Offset (0x4C),
trailing whitespace
Patch Set #1, Line 62: STRM, 8,
trailing whitespace
Patch Set #1, Line 63: Offset (0x4E),
trailing whitespace
Patch Set #1, Line 64: LIDE, 1,
trailing whitespace
Patch Set #1, Line 65: Offset (0x4F),
trailing whitespace
Patch Set #1, Line 66: ACID, 8,
trailing whitespace
trailing whitespace
Patch Set #1, Line 68: PTHM, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 70: BSEV, 1,
trailing whitespace
Patch Set #1, Line 71: DPTL, 1,
trailing whitespace
Patch Set #1, Line 72: Offset (0x52),
trailing whitespace
Patch Set #1, Line 73: ECLS, 1,
trailing whitespace
Patch Set #1, Line 74: Offset (0x55),
trailing whitespace
Patch Set #1, Line 75: EC45, 8,
trailing whitespace
Patch Set #1, Line 76: Offset (0x58),
trailing whitespace
Patch Set #1, Line 77: RTMP, 8,
trailing whitespace
Patch Set #1, Line 78: TNT1, 8,
trailing whitespace
Patch Set #1, Line 79: Offset (0x5F),
trailing whitespace
trailing whitespace
Patch Set #1, Line 81: Offset (0x61),
trailing whitespace
Patch Set #1, Line 82: SHPM, 8,
trailing whitespace
Patch Set #1, Line 83: Offset (0x67),
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 86: GC6R, 1,
trailing whitespace
Patch Set #1, Line 87: IGC6, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 89: PVSE, 1,
trailing whitespace
Patch Set #1, Line 90: PVSS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 92: PLGS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 94: TPDF, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 96: BCTF, 1,
trailing whitespace
Patch Set #1, Line 97: BMNF, 1,
trailing whitespace
Patch Set #1, Line 98: BTVD, 1,
trailing whitespace
Patch Set #1, Line 99: BF10, 1,
trailing whitespace
Patch Set #1, Line 100: Offset (0x6C),
trailing whitespace
Patch Set #1, Line 101: GWKR, 8,
trailing whitespace
Patch Set #1, Line 102: Offset (0x70),
trailing whitespace
Patch Set #1, Line 103: BADC, 16,
trailing whitespace
Patch Set #1, Line 104: BFCC, 16,
trailing whitespace
Patch Set #1, Line 105: BVLB, 8,
trailing whitespace
Patch Set #1, Line 106: BVHB, 8,
trailing whitespace
Patch Set #1, Line 107: BDVO, 8,
trailing whitespace
Patch Set #1, Line 108: Offset (0x7F),
trailing whitespace
Patch Set #1, Line 109: ECTB, 1,
trailing whitespace
Patch Set #1, Line 110: Offset (0x82),
trailing whitespace
Patch Set #1, Line 111: MBST, 8,
trailing whitespace
Patch Set #1, Line 112: MCUR, 16,
trailing whitespace
Patch Set #1, Line 113: MBRM, 16,
trailing whitespace
Patch Set #1, Line 114: MBCV, 16,
trailing whitespace
Patch Set #1, Line 115: Offset (0x8B),
trailing whitespace
Patch Set #1, Line 116: LEDM, 3,
trailing whitespace
Patch Set #1, Line 117: Offset (0x8D),
trailing whitespace
trailing whitespace
Patch Set #1, Line 119: MBFC, 1,
trailing whitespace
Patch Set #1, Line 120: Offset (0x92),
trailing whitespace
Patch Set #1, Line 121: SPSV, 8,
trailing whitespace
Patch Set #1, Line 122: Offset (0x94),
trailing whitespace
Patch Set #1, Line 123: GSSU, 1,
trailing whitespace
Patch Set #1, Line 124: GSMS, 1,
trailing whitespace
Patch Set #1, Line 125: Offset (0x95),
trailing whitespace
Patch Set #1, Line 126: MMST, 4,
trailing whitespace
Patch Set #1, Line 127: DMST, 4,
trailing whitespace
Patch Set #1, Line 128: Offset (0xA0),
trailing whitespace
Patch Set #1, Line 129: QBHK, 8,
trailing whitespace
Patch Set #1, Line 130: Offset (0xA2),
trailing whitespace
Patch Set #1, Line 131: QBBB, 8,
trailing whitespace
Patch Set #1, Line 132: Offset (0xA4),
trailing whitespace
Patch Set #1, Line 133: MBTS, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 135: BACR, 1,
trailing whitespace
Patch Set #1, Line 136: Offset (0xA6),
trailing whitespace
Patch Set #1, Line 137: MBDC, 8,
trailing whitespace
Patch Set #1, Line 138: Offset (0xA8),
trailing whitespace
Patch Set #1, Line 139: ENWD, 1,
trailing whitespace
Patch Set #1, Line 140: TMPR, 1,
trailing whitespace
Patch Set #1, Line 141: Offset (0xAA),
trailing whitespace
trailing whitespace
Patch Set #1, Line 143: SMSZ, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 145: RCDS, 1,
trailing whitespace
Patch Set #1, Line 146: Offset (0xAD),
trailing whitespace
Patch Set #1, Line 147: SADP, 8,
trailing whitespace
Patch Set #1, Line 148: Offset (0xB2),
trailing whitespace
Patch Set #1, Line 149: RPM1, 8,
trailing whitespace
Patch Set #1, Line 150: RPM2, 8,
trailing whitespace
Patch Set #1, Line 151: Offset (0xBA),
trailing whitespace
Patch Set #1, Line 152: CLOW, 8,
trailing whitespace
Patch Set #1, Line 153: CMAX, 8,
trailing whitespace
Patch Set #1, Line 154: Offset (0xC1),
trailing whitespace
Patch Set #1, Line 155: DPPC, 8,
trailing whitespace
Patch Set #1, Line 156: Offset (0xC6),
trailing whitespace
trailing whitespace
Patch Set #1, Line 158: CVTS, 1,
trailing whitespace
Patch Set #1, Line 159: Offset (0xCE),
trailing whitespace
Patch Set #1, Line 160: NVDX, 8,
trailing whitespace
Patch Set #1, Line 161: ECDX, 8,
trailing whitespace
Patch Set #1, Line 162: EBPL, 1,
trailing whitespace
Patch Set #1, Line 163: Offset (0xD2),
trailing whitespace
trailing whitespace
Patch Set #1, Line 165: DLYE, 1,
trailing whitespace
Patch Set #1, Line 166: Offset (0xD4),
trailing whitespace
Patch Set #1, Line 167: PSHD, 8,
trailing whitespace
Patch Set #1, Line 168: PSLD, 8,
trailing whitespace
Patch Set #1, Line 169: DBPL, 8,
trailing whitespace
Patch Set #1, Line 170: STSP, 8,
trailing whitespace
Patch Set #1, Line 171: Offset (0xDA),
trailing whitespace
Patch Set #1, Line 172: PSIN, 8,
trailing whitespace
Patch Set #1, Line 173: PSKB, 1,
trailing whitespace
Patch Set #1, Line 174: PSTP, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 176: PWOL, 1,
trailing whitespace
Patch Set #1, Line 177: RTCE, 1,
trailing whitespace
Patch Set #1, Line 178: Offset (0xE0),
trailing whitespace
Patch Set #1, Line 179: DLYT, 8,
trailing whitespace
Patch Set #1, Line 180: DLY2, 8,
trailing whitespace
Patch Set #1, Line 181: Offset (0xE6),
trailing whitespace
Patch Set #1, Line 182: SFHK, 8,
trailing whitespace
Patch Set #1, Line 183: Offset (0xE9),
trailing whitespace
Patch Set #1, Line 184: DTMT, 8,
trailing whitespace
Patch Set #1, Line 185: PL12, 8,
trailing whitespace
Patch Set #1, Line 186: ETMT, 8,
trailing whitespace
Patch Set #1, Line 187: Offset (0xF2),
trailing whitespace
Patch Set #1, Line 188: ZPDD, 1,
trailing whitespace
trailing whitespace
Patch Set #1, Line 190: ENPA, 1,
trailing whitespace
Patch Set #1, Line 191: Offset (0xF4),
trailing whitespace
Patch Set #1, Line 192: SFAN, 8,
trailing whitespace
Patch Set #1, Line 193: Offset (0xF9),
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 386: /* TODO: revisit _Q8E _Q8F and wtf is _QE4 for? ? */
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/acpi/kb.asl:
trailing whitespace
trailing whitespace
Patch Set #1, Line 79: 0x3D,
trailing whitespace
Patch Set #1, Line 87: 0x1F,
trailing whitespace
Patch Set #1, Line 110: 0x001E2E4F,
trailing whitespace
Patch Set #1, Line 111: 0x02002E4F,
trailing whitespace
Patch Set #1, Line 141: 0x3D,
trailing whitespace
Patch Set #1, Line 149: 0x1F,
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/acpi/mainboard.asl:
trailing whitespace
Patch Set #1, Line 37: RTSE, 8,
trailing whitespace
Patch Set #1, Line 38: RTSA, 8,
trailing whitespace
Patch Set #1, Line 39: RTMN, 8,
trailing whitespace
Patch Set #1, Line 40: RTMA, 8,
trailing whitespace
Patch Set #1, Line 41: RTHR, 8,
trailing whitespace
Patch Set #1, Line 42: RTHA, 8,
trailing whitespace
Patch Set #1, Line 43: RTDY, 8,
trailing whitespace
Patch Set #1, Line 53: RTSE, 8,
trailing whitespace
Patch Set #1, Line 54: RTSA, 8,
trailing whitespace
Patch Set #1, Line 55: RTMN, 8,
trailing whitespace
Patch Set #1, Line 56: RTMA, 8,
trailing whitespace
Patch Set #1, Line 57: RTHR, 8,
trailing whitespace
Patch Set #1, Line 58: RTHA, 8,
trailing whitespace
Patch Set #1, Line 59: RTDY, 8,
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 185: AEAX, 32,
trailing whitespace
Patch Set #1, Line 186: AEBX, 32,
trailing whitespace
Patch Set #1, Line 187: AECX, 32,
trailing whitespace
Patch Set #1, Line 188: AEDX, 32,
trailing whitespace
Patch Set #1, Line 189: AREF, 32,
trailing whitespace
Patch Set #1, Line 190: DAB0, 8,
trailing whitespace
Patch Set #1, Line 191: DAB1, 8,
trailing whitespace
Patch Set #1, Line 192: DAB2, 8,
trailing whitespace
Patch Set #1, Line 193: DAB3, 8,
trailing whitespace
Patch Set #1, Line 194: WBUF, 1024,
trailing whitespace
Patch Set #1, Line 195: TJMX, 8,
trailing whitespace
Patch Set #1, Line 196: FNKY, 8,
trailing whitespace
Patch Set #1, Line 197: CAME, 8,
trailing whitespace
Patch Set #1, Line 198: VTDT, 8,
trailing whitespace
Patch Set #1, Line 199: DPMD, 8,
trailing whitespace
Patch Set #1, Line 200: WLVD, 16,
trailing whitespace
Patch Set #1, Line 201: WLDD, 16,
trailing whitespace
Patch Set #1, Line 202: WLSV, 16,
trailing whitespace
Patch Set #1, Line 203: WLSS, 16,
trailing whitespace
Patch Set #1, Line 204: BTVD, 16,
trailing whitespace
Patch Set #1, Line 205: BTDD, 16,
trailing whitespace
Patch Set #1, Line 206: WWVD, 16,
trailing whitespace
Patch Set #1, Line 207: WWDD, 16,
trailing whitespace
Patch Set #1, Line 208: WMVD, 16,
trailing whitespace
Patch Set #1, Line 209: WMDD, 16,
trailing whitespace
Patch Set #1, Line 210: GPVD, 16,
trailing whitespace
Patch Set #1, Line 211: GPDD, 16,
trailing whitespace
Patch Set #1, Line 212: SMA4, 8,
trailing whitespace
Patch Set #1, Line 213: PMEE, 8,
trailing whitespace
Patch Set #1, Line 214: WSD0, 8,
trailing whitespace
Patch Set #1, Line 215: WSD1, 8,
trailing whitespace
Patch Set #1, Line 216: WSD2, 8,
trailing whitespace
Patch Set #1, Line 217: WSD3, 8,
trailing whitespace
Patch Set #1, Line 218: WAR7, 8,
trailing whitespace
Patch Set #1, Line 219: DBCM, 8,
trailing whitespace
Patch Set #1, Line 220: CPUP, 64,
trailing whitespace
Patch Set #1, Line 221: GPUP, 32,
trailing whitespace
Patch Set #1, Line 222: SYSP, 64,
trailing whitespace
Patch Set #1, Line 223: FANP, 32,
trailing whitespace
Patch Set #1, Line 224: BATP, 32,
trailing whitespace
Patch Set #1, Line 225: HDDP, 32,
trailing whitespace
Patch Set #1, Line 226: CPUT, 8,
trailing whitespace
Patch Set #1, Line 227: GPUT, 8,
trailing whitespace
Patch Set #1, Line 228: SYST, 8,
trailing whitespace
Patch Set #1, Line 229: FANT, 8,
trailing whitespace
Patch Set #1, Line 230: BATT, 8,
trailing whitespace
Patch Set #1, Line 231: TTST, 8,
trailing whitespace
Patch Set #1, Line 232: RTCF, 8,
trailing whitespace
Patch Set #1, Line 233: BODD, 8,
trailing whitespace
Patch Set #1, Line 234: BRTM, 8,
trailing whitespace
Patch Set #1, Line 235: NOCD, 8,
trailing whitespace
Patch Set #1, Line 236: PWVD, 16,
trailing whitespace
Patch Set #1, Line 237: PWDD, 16,
trailing whitespace
Patch Set #1, Line 238: PWSV, 16,
trailing whitespace
Patch Set #1, Line 239: PWSS, 16,
trailing whitespace
Patch Set #1, Line 240: Offset (0x400),
trailing whitespace
trailing whitespace
Patch Set #1, Line 267: 0xC350,
trailing whitespace
Patch Set #1, Line 268: Ones,
trailing whitespace
Patch Set #1, Line 269: Ones,
trailing whitespace
Patch Set #1, Line 270: 0xC350,
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/acpi/tpm.asl:
Patch Set #1, Line 122: Offset (0x04),
trailing whitespace
Patch Set #1, Line 123: LCST, 32,
trailing whitespace
Patch Set #1, Line 124: Offset (0x40),
trailing whitespace
Patch Set #1, Line 125: CREQ, 32,
trailing whitespace
Patch Set #1, Line 126: CSTS, 32,
trailing whitespace
Patch Set #1, Line 127: Offset (0x4C),
trailing whitespace
Patch Set #1, Line 134: Offset (0x04),
trailing whitespace
Patch Set #1, Line 135: HERR, 32,
trailing whitespace
Patch Set #1, Line 136: Offset (0x40),
trailing whitespace
Patch Set #1, Line 137: HCMD, 32,
trailing whitespace
Patch Set #1, Line 170: Offset (0x04),
trailing whitespace
Patch Set #1, Line 171: FERR, 32,
trailing whitespace
Patch Set #1, Line 172: Offset (0x0C),
trailing whitespace
trailing whitespace
trailing whitespace
trailing whitespace
Patch Set #1, Line 276: RQST, 32,
trailing whitespace
Patch Set #1, Line 277: RCNT, 32,
trailing whitespace
Patch Set #1, Line 278: ERRO, 32,
trailing whitespace
Patch Set #1, Line 279: FLAG, 32,
trailing whitespace
Patch Set #1, Line 280: MISC, 32,
trailing whitespace
Patch Set #1, Line 281: OPTN, 32,
trailing whitespace
Patch Set #1, Line 323: Zero,
trailing whitespace
Patch Set #1, Line 337: Zero,
trailing whitespace
Patch Set #1, Line 338: Zero,
trailing whitespace
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/devicetree.cb:
Patch Set #1, Line 45: register "EnableSata" = "0" # do we actually need this with only nvme?
trailing whitespace
trailing whitespace
Patch Set #1, Line 219: device pci 1f.4 on end # SMBus
trailing whitespace
File src/mainboard/hp/spectre_x360_13t_ae000/hda_verb.h:
trailing whitespace
trailing whitespace
To view, visit change 34946. To unsubscribe, or for help writing mail filters, visit settings.