Looks pretty good
Patch set 14:Code-Review +1
4 comments:
File src/mainboard/asus/p5ql-em/devicetree.cb:
Patch Set #11, Line 26: subsystemid 0x1043 0x8336
> Factor out and inherit? […]
Mainboard-specific quirks are usually related to firmware. I don't really mind, though.
File src/mainboard/asus/p5ql-em/dsdt.asl:
Scope (\_SB) {
Device (PCI0)
{
> Device (\_SB.PCI0) { […]
autoport uses this: https://github.com/coreboot/coreboot/blob/master/util/autoport/main.go#L879
File src/mainboard/asus/p5ql-em/romstage.c:
static u8 msr_get_fsb(void)
{
u8 fsbcfg;
msr_t msr;
const u32 eax = cpuid_eax(1);
/* Netburst */
if (((eax >> 8) & 0xf) == 0xf) {
msr = rdmsr(MSR_EBC_FREQUENCY_ID);
fsbcfg = (msr.lo >> 16) & 0x7;
} else { /* Intel Core 2 */
msr = rdmsr(MSR_FSB_FREQ);
fsbcfg = msr.lo & 0x7;
}
return fsbcfg;
}
> Would it be worth factoring out this function into a more generic place? It seems to fit better as […]
Ack
COMB_LPC_EN
| COMA_LPC_EN
> One of the serial ports of the SuperIO is disabled, so this seems unnecessary […]
Ack
To view, visit change 31323. To unsubscribe, or for help writing mail filters, visit settings.