Felix Held merged this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Felix Held: Looks good to me, approved
  HAOUAS Elyes: Looks good to me, approved
  Angel Pons: Looks good to me, approved

sb/intel/i82801gx: Include chip.h directly

Change-Id: I3d743e90444292be687999ab4f50aa89d514fbad
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33171
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/lenovo/t60/mainboard.c
M src/mainboard/lenovo/x60/mainboard.c
M src/mainboard/lenovo/z61t/mainboard.c
M src/southbridge/intel/i82801gx/i82801gx.h
M src/southbridge/intel/i82801gx/ide.c
M src/southbridge/intel/i82801gx/lpc.c
M src/southbridge/intel/i82801gx/pcie.c
M src/southbridge/intel/i82801gx/sata.c
8 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/lenovo/t60/mainboard.c b/src/mainboard/lenovo/t60/mainboard.c
index 2d998fb..b78d862 100644
--- a/src/mainboard/lenovo/t60/mainboard.c
+++ b/src/mainboard/lenovo/t60/mainboard.c
@@ -22,6 +22,7 @@
 #include <ec/lenovo/h8/h8.h>
 #include <ec/acpi/ec.h>
 #include <northbridge/intel/i945/i945.h>
+#include <southbridge/intel/i82801gx/chip.h>
 #include <drivers/intel/gma/int15.h>
 #include <arch/acpigen.h>
 
diff --git a/src/mainboard/lenovo/x60/mainboard.c b/src/mainboard/lenovo/x60/mainboard.c
index 274a151..964e9c0 100644
--- a/src/mainboard/lenovo/x60/mainboard.c
+++ b/src/mainboard/lenovo/x60/mainboard.c
@@ -22,6 +22,7 @@
 #include <arch/io.h>
 #include <ec/acpi/ec.h>
 #include <northbridge/intel/i945/i945.h>
+#include <southbridge/intel/i82801gx/chip.h>
 #include "dock.h"
 #include <drivers/intel/gma/int15.h>
 #include <drivers/lenovo/lenovo.h>
diff --git a/src/mainboard/lenovo/z61t/mainboard.c b/src/mainboard/lenovo/z61t/mainboard.c
index 886b4fb..5f59946 100644
--- a/src/mainboard/lenovo/z61t/mainboard.c
+++ b/src/mainboard/lenovo/z61t/mainboard.c
@@ -22,6 +22,7 @@
 #include <ec/lenovo/h8/h8.h>
 #include <ec/acpi/ec.h>
 #include <northbridge/intel/i945/i945.h>
+#include <southbridge/intel/i82801gx/chip.h>
 #include <drivers/intel/gma/int15.h>
 #include <arch/acpigen.h>
 
diff --git a/src/southbridge/intel/i82801gx/i82801gx.h b/src/southbridge/intel/i82801gx/i82801gx.h
index a91ffc5..e44fcf5 100644
--- a/src/southbridge/intel/i82801gx/i82801gx.h
+++ b/src/southbridge/intel/i82801gx/i82801gx.h
@@ -36,7 +36,6 @@
 
 #if !defined(__ASSEMBLER__)
 #if !defined(__PRE_RAM__)
-#include "chip.h"
 #if !defined(__SIMPLE_DEVICE__)
 void i82801gx_enable(struct device *dev);
 #endif
diff --git a/src/southbridge/intel/i82801gx/ide.c b/src/southbridge/intel/i82801gx/ide.c
index a362372..672ee43 100644
--- a/src/southbridge/intel/i82801gx/ide.c
+++ b/src/southbridge/intel/i82801gx/ide.c
@@ -19,6 +19,7 @@
 #include <device/pci.h>
 #include <device/pci_ops.h>
 #include <device/pci_ids.h>
+#include "chip.h"
 #include "i82801gx.h"
 
 typedef struct southbridge_intel_i82801gx_config config_t;
diff --git a/src/southbridge/intel/i82801gx/lpc.c b/src/southbridge/intel/i82801gx/lpc.c
index 948b6aa..846a709 100644
--- a/src/southbridge/intel/i82801gx/lpc.c
+++ b/src/southbridge/intel/i82801gx/lpc.c
@@ -34,6 +34,7 @@
 #include <southbridge/intel/common/acpi_pirq_gen.h>
 #include <southbridge/intel/common/pmbase.h>
 
+#include "chip.h"
 #include "i82801gx.h"
 #include "nvs.h"
 
diff --git a/src/southbridge/intel/i82801gx/pcie.c b/src/southbridge/intel/i82801gx/pcie.c
index 3e5dbc3..0946a9a 100644
--- a/src/southbridge/intel/i82801gx/pcie.c
+++ b/src/southbridge/intel/i82801gx/pcie.c
@@ -19,6 +19,7 @@
 #include <device/pci.h>
 #include <device/pci_ops.h>
 #include <device/pci_ids.h>
+#include "chip.h"
 #include "i82801gx.h"
 
 /* Low Power variant has 6 root ports. */
diff --git a/src/southbridge/intel/i82801gx/sata.c b/src/southbridge/intel/i82801gx/sata.c
index 8514b6d..b657513 100644
--- a/src/southbridge/intel/i82801gx/sata.c
+++ b/src/southbridge/intel/i82801gx/sata.c
@@ -20,6 +20,7 @@
 #include <device/pci.h>
 #include <device/pci_ops.h>
 #include <device/pci_ids.h>
+#include "chip.h"
 #include "i82801gx.h"
 #include "sata.h"

To view, visit change 33171. To unsubscribe, or for help writing mail filters, visit settings.