Attention is currently required from: Keith Hui, Kevin Keijzer.
Felix Singer has posted comments on this change by Kevin Keijzer. ( https://review.coreboot.org/c/coreboot/+/78806?usp=email )
Change subject: mb/asus/p8x7x-series: Add P8H77-M as a variant ......................................................................
Patch Set 3:
(4 comments)
File src/mainboard/asus/p8x7x-series/variants/p8h77-m/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/78806/comment/99f73c2a_bd1302e1?usp... : PS3, Line 11: AZALIA_PIN_CFG(0, 0x12, 0x411111f0), ```suggestion AZALIA_PIN_CFG(0, 0x12, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/78806/comment/e2d4b980_53759f71?usp... : PS3, Line 13: AZALIA_PIN_CFG(0, 0x15, 0x411111f0), : AZALIA_PIN_CFG(0, 0x16, 0x411111f0), : AZALIA_PIN_CFG(0, 0x17, 0x411111f0), ```suggestion AZALIA_PIN_CFG(0, 0x15, AZALIA_PIN_CFG_NC(0)), AZALIA_PIN_CFG(0, 0x16, AZALIA_PIN_CFG_NC(0)), AZALIA_PIN_CFG(0, 0x17, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/78806/comment/f982b67c_744c252b?usp... : PS3, Line 20: AZALIA_PIN_CFG(0, 0x1c, 0x411111f0), ```suggestion AZALIA_PIN_CFG(0, 0x1c, AZALIA_PIN_CFG_NC(0)), ```
https://review.coreboot.org/c/coreboot/+/78806/comment/83a86e4a_92468b78?usp... : PS3, Line 23: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x1f, AZALIA_PIN_CFG_NC(0)), ```