Patch Set 9: Code-Review+2

Looking at the patches upstream it seems the change in how gpio communities are reported was also a surprise to them. How is this decided at Intel?

Yes. There were lots of changes on the kernel side. Eventually we will go to the newer schema maybe in next silicon. But for TGL the change was too late to do proper validation so Intel decided to use the older schema.

View Change

2 comments:

• Commit Message:

  • Patch Set #9, Line 12:

    BUG=?

    Done

• File src/soc/intel/tigerlake/gpio.c:

  • Patch Set #7, Line 74:

    INTEL_GPP_BASE(GPP_C0, GPP_L_BKLTEN, GPP_MLK_RSTB, 320),	/* GPP_HVCMOS */
    	INTEL_GPP_BASE(GPP_C0, GPP_E0, GPP_E_CLK_LOOPBK, 352),		/* GPP_E */
    

    You will have to use INTEL_GPP for GPP_HVCMOS and GPP_JTAG. Also for GPP_SPI below. […]

    Done

To view, visit change 39801. To unsubscribe, or for help writing mail filters, visit settings.