4 comments:
File payloads/libpayload/drivers/nvram.c:
Please use defined constants (e.g. NVRAM_RTC_BINARY).
Done
File payloads/libpayload/drivers/nvram.c:
maybe give it a name? RTC_BINARY_FORMAT (with 0 == BCD)
Done
RTC_24HOURS?
Done
if (!(statusB & 0x02)) {
reg8 = nvram_read(NVRAM_RTC_HOURS);
time->tm_hour = reg8 & 0x7f;
time->tm_hour += (reg8 & 0x80) ? 12 : 0;
time->tm_hour %= 24;
} else
time->tm_hour = nvram_read(NVRAM_RTC_HOURS);
time->tm_year = nvram_read(NVRAM_RTC_YEAR);
factor out?
or maybe not...
To view, visit change 18498. To unsubscribe, or for help writing mail filters, visit settings.