the remaining thing I'm not sure about is if the ACPI entries for the MMIO UARTs should be hidden when PICASSO_UART_LEGACY is set, so that the same UARTs won't get exposed to the OS twice. If a SoC serial port is used as console, it'll still use the MMIO interface, but that is no issue there

View Change

To view, visit change 40322. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id08ff6428d4019303ebb6e44e13aba480cf1fde2
Gerrit-Change-Number: 40322
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 14 Sep 2020 18:42:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment