Attention is currently required from: Furquan Shaikh.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47831 )
Change subject: util/cbfstool: Introduce concept of mmap_window
......................................................................
Patch Set 16:
(1 comment)
File util/cbfstool/cbfstool.c:
https://review.coreboot.org/c/coreboot/+/47831/comment/fee0ff57_ae0c611e
PS16, Line 197: >=
region_end() is non-inclusive […]
static inline size_t region_end(const struct region *r)
{
return region_offset(r) + region_sz(r);
}
Looks a lot like 4 GiB, or 0 for 32-bit user space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47831
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8dd3d1c922cc834c1e67f279ffce8fa438d8209c
Gerrit-Change-Number: 47831
Gerrit-PatchSet: 16
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Thu, 11 Feb 2021 17:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment