Attention is currently required from: Christian Walter, Elyes Haouas, Felix Singer, Martin L Roth, Martin Roth, Name of user not set #1005382, Naveen Iyer, Paul Menzel.
View Change
1 comment:
Patchset:
Patch Set #7:
The regular build should be reproducible. If it isn't, that's a bug. […]
hmm, might be that i misremembered things or things changed in the last few years, but if the regular build already is reproducible, this might not be needed. back in the days, the regular build wasn't reproducible and i assumed that the date in the binary is the build date, but if it's the commit date nowadays, the regular build might already be reproducible. so it looks like i gave wrong advice based on what i thought was the case here :/
To view, visit change 82006. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I97b0c4ea654df23844f31a3398b6f0d05dfec1ab
Gerrit-Change-Number: 82006
Gerrit-PatchSet: 7
Gerrit-Owner: Naveen Iyer
Gerrit-Reviewer: Christian Walter <christian.walter@9elements.com>
Gerrit-Reviewer: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: Naveen Iyer
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-CC: Name of user not set #1005382
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Naveen Iyer
Gerrit-Attention: Name of user not set #1005382
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter@9elements.com>
Gerrit-Attention: Martin Roth <martin.roth@amd.corp-partner.google.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Mon, 22 Apr 2024 23:22:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Name of user not set #1005382
Comment-In-Reply-To: Martin Roth <martin.roth@amd.corp-partner.google.com>
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment