View Change
1 comment:
Commit Message:
Patch Set #4, Line 9: Disable FCH_48MHZ_CLK_OUT for LTE sku in next build.
Could you add explanation why 48MHz clock output needs to enabled from reset to end of ramstage? With no access to schema, I am assuming pin would not be routed to anything and should never be enabled for reference clock in the first place.
To view, visit change 48556. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida747938373f648524b1e7f34bc69e372a69c4f9
Gerrit-Change-Number: 48556
Gerrit-PatchSet: 4
Gerrit-Owner: John Su <john_su@compal.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: chris wang <Chris.Wang@amd.com>
Gerrit-CC: Alan Lee <alan_lee@compal.corp-partner.google.com>
Gerrit-CC: Amanda Hwang <amanda_hwang@compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu@compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu@compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng@compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian@compal.corp-partner.google.com>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Comment-Date: Mon, 14 Dec 2020 15:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment