Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35884 ) Change subject: soc/intel/Kconfig: Move MMCONF_BASE_ADDRESS out of a common place ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/apollolake/Kc... File src/soc/intel/apollolake/Kconfig: https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/apollolake/Kc... PS3, Line 84: SOC_INTEL_COMMON_BLOCK_SA This already defines MMCONF_BASE_ADDRESS https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/cannonlake/Kc... File src/soc/intel/cannonlake/Kconfig: https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/cannonlake/Kc... PS3, Line 98: SOC_INTEL_COMMON_BLOCK_SA This already defines MMCONF_BASE_ADDRESS https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/skylake/Kconf... File src/soc/intel/skylake/Kconfig: https://review.coreboot.org/c/coreboot/+/35884/3/src/soc/intel/skylake/Kconf... PS3, Line 63: SOC_INTEL_COMMON_BLOCK_SA This already defines MMCONF_BASE_ADDRESS -- To view, visit https://review.coreboot.org/c/coreboot/+/35884 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idcfea1718cc36ae16b491604786c26c6ed320f06 Gerrit-Change-Number: 35884 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org> Gerrit-Reviewer: Andrey Petrov <andrey.petrov@gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: David Guckian <d.guckian20@gmail.com> Gerrit-Reviewer: David Guckian <david.guckian@intel.com> Gerrit-Reviewer: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Wed, 22 Jul 2020 22:24:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment