12 comments:
APIs
Done
APIs
Done
Patch Set #2, Line 17: Type-A dongle on Volteer
no need to indent here
Done
Patch Set #2, Line 17: Type-A dongle on Volteer
no need to indent here
Done
EC being the TCPM decides the mux configuration after
negotiating with the port partner on the Type-C port. The APIs
added here will give the current essential mux state information
for a given port.
Please re-flow for 75 characters per line.
Done
File src/ec/google/chromeec/ec.h:
/* Check for the current mux state in EC
* in: int port physical port number of the type-c port
* out: uint8_t flags flags representing the status of the mux such as
* usb capability, dp capability, cable type, etc
*/
https://doc.coreboot.org/coding_style. […]
Done
Patch Set #5, Line 325: int google_chromeec_get_num_pd_ports(uint8_t *num_ports);
Why is the signature changed? Please stay with the “native” types like `unsigned int` or `size_t`.
changed this to unsigned int...there is no need for this to be an integer since there is no possible negative amount of ports
File src/ec/google/chromeec/ec.h:
Patch Set #2, Line 30: /* Check for the current mux state in EC */
I will update these to the best of my ability but they are not my area of expertise. […]
Done
* USB2 and USB3 port numbers between EC and AP
* is not one to one mapping, this function will return the
* correct mapped AP port number in port_map.
80 chars wide is OK here.
Done
Same thing, more documentation please. […]
Done
Patch Set #2, Line 39: int google_chromeec_usb_pd_control(int port, bool *ufp, bool *dbg_acc,
What are the possible values of dp_mode?
Done
File src/ec/google/chromeec/ec.c:
uint8_t num_ports;
int ret;
struct chromeec_command cmd;
int i;
ret = google_chromeec_get_num_pd_ports(&num_ports);
if (ret < 0)
return -1;
for (i = 0; i < num_ports; i++)
google_chromeec_pd_get_amode() alreacdy existed, so changing it from sending a "raw" command to call […]
ok sure I'll remove it in the next update
To view, visit change 42078. To unsubscribe, or for help writing mail filters, visit settings.