Attention is currently required from: YH Lin, Tim Wawrzynczak, Zhuohao Lee, Felix Held.

View Change

4 comments:

• File src/mainboard/google/brya/variants/moli/overridetree.cb:

  • Patch Set #2, Line 30:

    	register "wake" = "GPE0_PME_B0"
    					device generic 0 on end
    

    nit: one too many tabs here, remove extra one please

    done

  • Patch Set #2, Line 79:

    chip soc/intel/common/block/pcie/rtd3
    			register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_B3)"
    			register "srcclk_pin" = "1"
    			device generic 0 alias emmc_rtd3 on end
    		end # Enable PCIe-to-eMMC bridge PCIE 12 using clk 1
    

    please indent this section by one more tab

    done

  • Patch Set #2, Line 125: register "group" = "ACPI_PLD_GROUP(1, 1)"

    We are switching to using a more fully-specified _PLD object, can you please update this to match? S […]

    done

  • Patch Set #2, Line 196:

    tab please

    done

To view, visit change 62321. To unsubscribe, or for help writing mail filters, visit settings.