Arthur Heymans has uploaded this change for review.
cpu/x86/mp_init.c: Set a bogus initial lapic_id
This makes it easier to catch errors later if the ap_init code fails to
properly set things up.
Change-Id: I938faf042bfa4fe1fc39e78ab740c9b210bc105c
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
---
M src/cpu/x86/mp_init.c
1 file changed, 18 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/69108/1
diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c
index 8003ac5..d698634 100644
--- a/src/cpu/x86/mp_init.c
+++ b/src/cpu/x86/mp_init.c
@@ -374,9 +374,11 @@
/* Build the CPU device path */
cpu_path.type = DEVICE_PATH_APIC;
- /* Assuming linear APIC space allocation. AP will set its own
- APIC id in the ap_init() path above. */
- cpu_path.apic.apic_id = info->cpu->path.apic.apic_id + i;
+ /*
+ * Set a bogus apic_id.
+ * AP will set its own APIC id in the ap_init() path above.
+ */
+ cpu_path.apic.apic_id = UINT32_MAX;
/* Allocate the new CPU device structure */
new = alloc_find_dev(cpu_bus, &cpu_path);
To view, visit change 69108. To unsubscribe, or for help writing mail filters, visit settings.