View Change

5 comments:

• File Documentation/ifdtool/layout.md:

  • Patch Set #6:

    I think there's a line length limit for .md files, but I am not sure if it's specified anywhere

  • Patch Set #6, Line 9: SI_

    Maybe add quotes or backticks to highlight this prefix

  • Patch Set #6, Line 9: silicon initialization

    Same as SI_

  • Patch Set #6, Line 18: elsewhere

    I guess this implies the EC firmware is either on the EC itself or on a dedicated flash chip?

• File util/ifdtool/ifdtool.c:

  • Patch Set #6, Line 1671: mode_validate) == 0) {

    Very minor: Looks like this would fit on the previous line without exceeding the 96-character length limit

To view, visit change 34802. To unsubscribe, or for help writing mail filters, visit settings.