Asami Doi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33287 ) Change subject: payloads/libpayload: Update a Makefile and a wrappter of a compiler in libpayload in order to build sample payload for QEMU/ARM. ...................................................................... Patch Set 10: (1 comment) https://review.coreboot.org/#/c/33287/9/payloads/libpayload/include/arm/arch... File payloads/libpayload/include/arm/arch/io.h: https://review.coreboot.org/#/c/33287/9/payloads/libpayload/include/arm/arch... PS9, Line 43: #define outl(v, a) write32((void *) (&v), a)
Yes, Arm only uses MMIO. in/out I/O ports are a totally x86-specific thing. Please remove these. […] I see. Thank you for your comment. I removed these.
-- To view, visit https://review.coreboot.org/c/coreboot/+/33287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia32872c43a99357aa966de3582f6fdb2e2652517 Gerrit-Change-Number: 33287 Gerrit-PatchSet: 10 Gerrit-Owner: Asami Doi <d0iasm.pub@gmail.com> Gerrit-Reviewer: Asami Doi <d0iasm.pub@gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Julius Werner <jwerner@chromium.org> Gerrit-CC: Raul Rangel <rrangel@chromium.org> Gerrit-Comment-Date: Tue, 11 Jun 2019 03:41:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner@chromium.org> Gerrit-MessageType: comment